Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuousmode
From: Patrick McHardy
Date: Fri Nov 16 2007 - 09:46:47 EST
Herbert Xu wrote:
BTW, how does the VLAN TX acceleration work at all? It's using
skb->cb to carry the tags but then calls dev_queue_xmit. Once
you do that packet schedulers can scribble all over skb->cb.
Also vlan_skb_recv should be moved out-of-line. It's absolutely
humongous. It'll generate tail-calls anyway so performance-wise
it's useless.
I have a number of VLAN cleanups queued and intend to do these
two changes on top.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/