Re: [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplugimplementation

From: Ingo Molnar
Date: Thu Nov 15 2007 - 10:35:19 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Gautham R Shenoy <ego@xxxxxxxxxx> wrote:
>
> > void lock_cpu_hotplug(void)
> > {
> > - struct task_struct *tsk = current;
> > -
> > - if (tsk == recursive) {
> > - static int warnings = 10;
> > - if (warnings) {
> > - printk(KERN_ERR "Lukewarm IQ detected in hotplug locking\n");
> > - WARN_ON(1);
> > - warnings--;
> > - }
> > - recursive_depth++;
>
> i nominate it for a 2.6.24 merge due to it fixing the above
> regression. I've seen regular instances of the "Lukewarm IQ" message.

FYI, i've put these 3 patches into the scheduler git tree and it's
looking very good so far. So unless Andrew or Linus objects to put this
into v2.6.24, or there's serious questions during review, could we merge
it this way?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/