Re: [patch 5/8] Immediate Values - x86 Optimization

From: H. Peter Anvin
Date: Tue Nov 13 2007 - 14:39:57 EST


Mathieu Desnoyers wrote:
- Use "=g" constraint for char immediate value inline assembly.

"=g" is the same as "=rmi" which is inherently bogus. In your actual code you use "=r", the correct constraint is "=q".

q
Any register accessible as rl. In 32-bit mode, a, b, c, and d; in 64-bit mode, any integer register.


I am worried that "=q" might exclude the si and di registers in 32-bit mode.

What exactly is wrong with "=r" ?


For "char" (8-bit) values, sp/bp/si/di are illegal in 32-bit mode.

Hence "=q".

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/