Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

[David Howells]

Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> memory mapped registers should be read with readw and friends and that
> should contain the volatile not the public code.

Actually, I can think of a good reason for *not* doing that.  What I have at
the moment encodes the size of the register to be accessed in the type.  What
you're suggesting does not.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/