Re: ARM defconfig bogosity in current git

From: Adrian Bunk
Date: Sat Nov 10 2007 - 06:50:28 EST


On Sat, Nov 10, 2007 at 12:26:32PM +0100, Robert Schwebel wrote:
> On Sat, Nov 10, 2007 at 09:10:57AM +0000, Russell King wrote:
> > > diff --git a/arm/configs/netx_defconfig b/arm/configs/netx_defconfig
> > > new file mode 100644
> > > index 0000000..57f32f3
> > > --- /dev/null
> > > +++ b/arm/configs/netx_defconfig
> > >
> > > ...
> > >
> > > Isn't there something in Documentation/ about -p1 being a good idea
> > > precisely so this sort of silliness is avoided?
> >
> > -p1 doesn't avoid this when the patch just contains new files.
> > Unfortunately, you have to rely both on people spotting such things
> > and whoever's generating the patch doing the right thing.
> >
> > There will be times when things slip through though.
> >
> > > Currently this breaks tab completion on arch/, which is very much a
> > > regression ;-)
> >
> > Robert?
>
> Aaargh, that came from a broken script changing the patch from p0 to p1...
> Please simply revert that patch, I'll send a new and correct one.

You should also check what you sent - the contents of this file was
exactly the same as arch/arm/configs/netx_defconfig is since one year.

> Sorry for the noise.
>
> Robert

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/