Re: ARM defconfig bogosity in current git

[Russell King]

On Sat, Nov 10, 2007 at 05:06:29PM +0900, Paul Mundt wrote:
> The last ARM merge contained this gem:
> 
> commit f33bac8dd4573428b94c67149c5607be489092d1
> Author: Robert Schwebel <robert@xxxxxxxxxxx>
> Date:   Mon Nov 5 17:59:25 2007 +0100
> 
>     [ARM] 4642/2: netX: default config for netx based boards
>     
>     This patch updates the default config file for netx based boards.
>     
>     Signed-off-by: Robert Schwebel <r.schwebel@xxxxxxxxxxxxxx>
>     Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>     Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> 
> diff --git a/arm/configs/netx_defconfig b/arm/configs/netx_defconfig
> new file mode 100644
> index 0000000..57f32f3
> --- /dev/null
> +++ b/arm/configs/netx_defconfig
> 
> ...
> 
> Isn't there something in Documentation/ about -p1 being a good idea
> precisely so this sort of silliness is avoided?

-p1 doesn't avoid this when the patch just contains new files.
Unfortunately, you have to rely both on people spotting such things
and whoever's generating the patch doing the right thing.

There will be times when things slip through though.

> Currently this breaks tab completion on arch/, which is very much a
> regression ;-)

Robert?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/