Re: dio_get_page() lockdep complaints

From: Chris Mason
Date: Fri Nov 09 2007 - 13:02:51 EST


On Fri, 09 Nov 2007 09:48:22 -0800
Zach Brown <zach.brown@xxxxxxxxxx> wrote:

>
> >> So reiser and NFS need to be fixed. No?
> >
> > Actually, it is rather mmap() needs to be fixed.
>
> Sure, I'm willing to have that demonstrated. My point was that DIO
> getting the mmap_sem inside i_mutex is currently correct.
>
> reiserfs, though, seems to be out on a more precarious limb ;).

reiserfs is doing tail packing during the file_release call, which has
lots of advantages for removing complexity in file_write.

Without getting into a huge patch, the best fix would just be switching
to try lock. If the tail doesn't get packed, the world doesn't end.

-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/