Re: [patch 01/28] cpu alloc: The allocator

From: David Miller
Date: Thu Nov 08 2007 - 18:51:03 EST


From: Christoph Lameter <clameter@xxxxxxx>
Date: Thu, 8 Nov 2007 12:24:22 -0800 (PST)

> On Thu, 8 Nov 2007, Peter Zijlstra wrote:
>
> > > The convention for macros is to use upper case.
> >
> > We have plent macros that look like regular functions. And as a primary
> > interface to this functionality these shouting things look really out of
> > place.
>
> One point of the patchset is to clean up the messy handling of the
> allocpercpu interface which uses lower case for macros. It is a bit
> confusing that a function like alloc_percpu() can take a type argument.
> I think this needs to be uppercase for clarity.

Without a doubt.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/