..On Thu, 8 Nov 2007 13:19:05 -0500 Jeff Garzik <jeff@xxxxxxxxxx> wrote:
On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote:
On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik <jeff@xxxxxxxxxx> wrote:
On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote:
..I suspect it wold be best to disable the feature for the 2.6.24 release,Re-read my message :)
then reenable it afterwards and keep doing this until the code is
sufficiently stable.
The code is stable. Behavior _by definition_ will vary by BIOS.
This feature (a) enables suspend/resume, but (b) now sends random
unvalidated shite to the device that we hope will work.
Look at all the messages where turning on ACPI in libata _fixed_
suspend/resume (because its obviously required for many, including
laptops).
We fixed a somewhat-known number of machines and broke an unknown number. Linus will come after you with a pointy stick if he finds out.
Fixing previously-broken machines is nice, but breaking previously-working
ones gets people a lot more upset.
So it's not an easy "turn it off" answer, you break shitloads of
suspend/resume that way, that we just fixed.
The message "_GTF unexpected object type" indicates a broken BIOS, so
IMO we should proceed in that direction, blacklisting that platform.
Suggest that the feature be disabled until we have most of these
blacklistings in place.