Re: Re: pktcdvd oops

From: Peter Osterlund
Date: Thu Nov 08 2007 - 12:49:59 EST


On Thu, 8 Nov 2007, balagi@xxxxxxxxxxx wrote:

tested it too, running linux 2.6.23 in a qemu instance, and the patch worked. But i would prefer to take the try_module_get() stuff into pkt_setup_dev() because it is used also in the older procfs interface. Can we run into the same problem here, means procfs holds no module references too, like sysfs now?

The procfs interface can only be used to get some debug data out from the driver, not to bind the driver to a CD/DVD device, so it shouldn't be a problem.

The other way to bind a device is to use the pktsetup program, which is doing ioctl calls to the driver. In that case, user space has to open the device before being able to do the ioctls, and the open call will increase the reference count.

--
Peter Osterlund - petero2@xxxxxxxxx
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/