Re: compat_sys_times() bogus until jiffies >= 0.

From: Andrew Morton
Date: Wed Nov 07 2007 - 20:14:53 EST


> On Wed, 07 Nov 2007 16:50:22 -0800 (PST) David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 7 Nov 2007 15:28:33 -0800
>
> > Perhaps this is a bug in glibc: it is interpreting the times() return value
> > in the same way as other syscalls.
>
> The problem is more likely that we are failing to
> invoke force_successful_syscall_return() here.
>
> Otherwise the syscall return path interprets negative
> values as errors, and sets the cpu condition codes.
>
> And that is what userspace is actually checking for
> to determine if there is an error or not.

hm, I'd forgotten about that.

It seems to be a no-op on lots of architectures?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/