Re: [PATCH] mm/memory.c: remove warning from an uninitializedspinlock. was: Re: 2.6.21-rc7-mm2

From: Steven Rostedt
Date: Wed Nov 07 2007 - 14:20:58 EST


>
> Introduce a macro for suppressing gcc from generating a warning about a
> probable uninitialized state of a variable.
>
> Example:
>
> - spinlock_t *ptl;
> + spinlock_t *uninitialized_var(ptl);
>
> Not a happy solution, but those warnings are obnoxious.
>
> - Using the usual pointlessly-set-it-to-zero approach wastes several
> bytes of text.
>
> - Using a macro means we can (hopefully) do something else if gcc changes
> cause the `x = x' hack to stop working
>
> - Using a macro means that people who are worried about hiding true bugs
> can easily turn it off.
>
> Signed-off-by: Borislav Petkov <bbpetkov@xxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

I just stumbled across this being in the kernel. Well, I'm finally glad
it made it in, even though it was suggested one year earlier ;-)

http://lkml.org/lkml/2006/5/11/50

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/