Re: [PATCH] cfq: fix IOPRIO_CLASS_IDLE delays

[Jens Axboe]

On Tue, Nov 06 2007, Oleg Nesterov wrote:
> After the fresh boot:
> 
> 	ionice -c3 -p $$
> 	echo cfq >> /sys/block/XXX/queue/scheduler
> 	dd if=/dev/XXX of=/dev/null bs=512 count=1
> 
> Now dd hangs in D state and the queue is completely stalled for approximately
> INITIAL_JIFFIES + CFQ_IDLE_GRACE jiffies. This is because cfq_init_queue()
> forgets to initialize cfq_data->last_end_request.

Another good catch, thanks Oleg!

> (I guess this patch is not complete, overflow is still possible)

Hmm, where would it overflow?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/