Re: [PATCH] Add the macro to test if "exactly_one_bit_set" to log2.h.

From: Boaz Harrosh
Date: Tue Nov 06 2007 - 13:14:32 EST


On Tue, Nov 06 2007 at 18:38 +0200, "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> wrote:
> While this macro is defined in terms of "is_power_of_2" and is
> therefore functionally equivalent, the visual semantics are sometimes
> more appropriate for what is actually being tested.
>
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
>
> ---
>
> diff --git a/include/linux/log2.h b/include/linux/log2.h
> index c8cf5e8..d0d324e 100644
> --- a/include/linux/log2.h
> +++ b/include/linux/log2.h
> @@ -55,6 +55,12 @@ bool is_power_of_2(unsigned long n)
> }
>
> /*
> + * And for folks who want slightly different semantics ...
> + */
> +
> +#define exactly_one_bit_set is_power_of_2

at_most_one_bit_set No?
> +
> +/*
> * round up to nearest power of two
> */
> static inline __attribute__((const))

Boaz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/