Re: [GIT PULL] x86 setup: correct booting on 486 (revised)

From: H. Peter Anvin
Date: Mon Nov 05 2007 - 15:31:48 EST


Eric W. Biederman wrote:

However, that being said, doing so is trivial, and it might help some
debugging hack; anything that makes debugging easier is a Good Thing[TM].
Yeah. Even if it was just re-using the boot-time stack area temporarily, just to give code the choice to use a common set of instructions.

If I had to do it from scratch today I would make the 32-bit entry
point require a stack, segments and use C calling conventions to pass
struct boot_params *.

Besides %esi I'm not really fond of requiring anything in the 32bit
entrypoint. At the same time I totally agree that it is always nice
to provide way more then you need.


Nailing down the interface as hard as possible is a good idea, to avoid tying your hands for the future.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/