Re: [PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting

From: Jens Axboe
Date: Mon Nov 05 2007 - 03:01:19 EST


On Sun, Nov 04 2007, Oleg Nesterov wrote:
> (untested, needs an ack from maintainer)
>
> Spotted by Nick <gentuu@xxxxxxxxx>, hopefully can explain the second trace in
> http://bugzilla.kernel.org/show_bug.cgi?id=9180.
>
> If ->async_idle_cfqq != NULL cfq_put_async_queues() puts it IOPRIO_BE_NR times
> in a loop. Fix this.

That's obviously buggy, thanks Oleg! Fix is indeed correct. I'll add it.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/