Re: duplicated include files

From: Adrian Bunk
Date: Sun Nov 04 2007 - 14:04:22 EST


On Sun, Nov 04, 2007 at 01:37:31PM -0500, Robert P. J. Day wrote:
> On Sun, 4 Nov 2007, Randy Dunlap wrote:
>
> > On Sun, 4 Nov 2007 12:31:38 -0500 (EST) Robert P. J. Day wrote:
> >
> > >
> > > given the recent patches to remove duplicated #include preprocessor
> > > directives in source files, let it be known that there are a number of
> > > them:
> > >
> > > http://www.crashcourse.ca/wiki/index.php/Duplicate_include_files
> > >
> > > help yourself.
> >
> > Could you make the tool (script?) available also, please?
>
> trust me, it's not a script i'm particularly proud of:
>
> ===========================
> #!/bin/sh
>
> DIR=${1-*} # by default, all directories
>
> for cf in $(find ${DIR} -name *.c) ; do
> echo ${cf}
> grep "#include" $cf | sort | uniq -c | grep -v 1
> done | grep -B1 "#include" | grep -v -- "--"
> ===========================
>
> on the bright side, it took about 90 seconds to write, but i won't
> be winning any awards for style.
>
> i'll add it to the web page.


BTW: "make includecheck" already does the same...


> rday


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/