Re: per-bdi-throttling: synchronous writepage doesn't workcorrectly

[Miklos Szeredi]

> > 
> >       See the file "Locking" for more details.
> > 
> > 
> > The "should set PG_Writeback" bit threw me off I guess.
> 
> Hmm, set_page_writeback() is also the one clearing the radix tree dirty
> tag. So if that is not called, we get in a bit of a mess, no?
> 
> Which makes me think hostfs is buggy.

Yes, looks like that sort of usage is not valid.  But not clearing the
dirty tag won't cause any malfunction, it'll just waste some CPU when
looking for dirty pages to write back.  This is probably why this
wasn't noticed earlier.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/