Re: per-bdi-throttling: synchronous writepage doesn't workcorrectly

[Miklos Szeredi]

> > Hi,
> > 
> > It looks like bdi_thresh will always be zero if filesystem does
> > synchronous writepage, resulting in very poor write performance.
> > 
> > Hostfs (UML) is one such example, but there might be others.
> > 
> > The only solution I can think of is to add a set_page_writeback();
> > end_page_writeback() pair (or some reduced variant, that only does
> > the proportions magic).  But that means auditing quite a few
> > filesystems...
> 
> Ouch...
> 
> I take it there is no other function that is shared between all these
> writeout paths which we could stick a bdi_writeout_inc(bdi) in?

No, and you can't detect it from the callers either I think.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/