Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

From: Alan Cox
Date: Thu Nov 01 2007 - 11:47:50 EST


On Thu, 1 Nov 2007 11:55:56 +0100 (CET)
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> tty, add tty_schedule_wakeup
>
> Because several drivers schedule a workqueue only for tty_wakeup, move this
> functionality into tty layer and use newly added centralized work.

I've no idea why any drivers do this. A tty_wakeup is very fast and it
won't (when called from an IRQ) reschedule anything until the IRQ is over
(in the RT kernel case it might do stuff but thats *because* it should do
so).

I think just using tty_wakeup for this ought to be sufficient unless they
are using the work queue for some kind of serialization of events
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/