Re: [PATCH 0/4] Unexport several headers and cleanup

[David Woodhouse]

On Tue, 2007-10-30 at 15:50 +0200, Kirill A. Shutemov wrote:
> It's bad idea. Taken from directfb:
> 
> #if HAVE_ASM_PAGE_H
> #include <asm/page.h>
> #else
> #define PAGE_SIZE   sysconf( _SC_PAGESIZE )
> #endif
> 
> Other application can use something like this. I think we should drop
> empty headers.

Well, it ought to be using sysconf unconditionally, but I take your
point. I'm happy enough then -- and since it doesn't change the kernel
build it could perhaps even be considered for 2.6.24.

Here you are... make sure you use them in the correct order:
Reviewed-By: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Reviewed-By: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Reviewed-By: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Reviewed-By: David Woodhouse <dwmw2@xxxxxxxxxxxxx>

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/