Re: [PATCH] PCMCIA: prevent auto insert during resume.

[Rodolfo Giometti]

On Fri, Oct 26, 2007 at 05:02:06PM +0100, Russell King wrote:
> 
> Not on a battery powered device with a graphical interface.

This can be done by a button, menu or other graphical object. :)

> > On battery powered device I should prevent power lost, so if I power
> > down a device I'd like it should remain off even after resume.
> 
> In which case you need to remember why it was powered down and act
> accordingly.

Yes. This have some reasons... for example, my custom board has a WiFi
connected to the PCMCIA interface (which consumes a lot of power) and
if the user switch off the WiFi I think he/she doesn't wish the WiFi
is automagic powered on after resume... this behaviour can cause power
lost if the user forgot to switch it off again.

> > Why the system should power it on automagically? Just for detection?
> 
> When you bring the battery device out of resume, and you've inserted a
> card, you want it to be detected.  Your change means you have to wait
> until the system has finished resuming before you plug the card in,
> which practically is a pain in the butt and actually leads to user
> errors.  IOW:
> 
> "I plugged my wireless card in after I pressed the power button, why
> wasn't it detected?"

My patch doesn't affect the power on sequence, just the resume
one. Also if you didn't eject the socket, at resume the device will be
powered up again, my patch just prevents that a pre-powered off device
to be turned on at resume time.

However you should consider that some embedded systems have fixed
PCMCIA devices that can't be removed so there are no reasons to detect
them after resume, nobody can change them. :)

Also battery powered devices can go very frequently to sleep and the
current behavior force the user to switch off the unused device each
time the system resumes from sleep.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@xxxxxxxxxxxx
Linux Device Driver                             giometti@xxxxxxxxx
Embedded Systems                     		giometti@xxxxxxxx
UNIX programming                     phone:     +39 349 2432127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/