Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

[Pekka Enberg]

Hi Hugh,

On 10/25/07, Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> @@ -349,10 +349,6 @@ static pageout_t pageout(struct page *pa
>                 res = mapping->a_ops->writepage(page, &wbc);
>                 if (res < 0)
>                         handle_write_error(mapping, page, res);
> -               if (res == AOP_WRITEPAGE_ACTIVATE) {
> -                       ClearPageReclaim(page);
> -                       return PAGE_ACTIVATE;
> -               }

I don't see ClearPageReclaim added anywhere. Is that done on purpose?
Other than that, the patch looks good to me and I think we should
stick it into -mm to punish Andrew for his secret hack ;-).

                                          Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/