[PATCH] cfq_get_queue: fix possible NULL pointer access

From: Oleg Nesterov
Date: Sat Oct 20 2007 - 09:06:56 EST


cfq_get_queue()->cfq_find_alloc_queue() can fail, check the returned value.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- K/block/cfq-iosched.c~3_get 2007-10-20 15:48:35.000000000 +0400
+++ K/block/cfq-iosched.c 2007-10-20 17:05:30.000000000 +0400
@@ -1443,8 +1443,11 @@ cfq_get_queue(struct cfq_data *cfqd, int
cfqq = *async_cfqq;
}

- if (!cfqq)
+ if (!cfqq) {
cfqq = cfq_find_alloc_queue(cfqd, is_sync, tsk, gfp_mask);
+ if (!cfqq)
+ return NULL;
+ }

/*
* pin the queue now that it's allocated, scheduler exit will prune it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/