Re: [RFC PATCH 0/5] Shadow directories

From: Al Viro
Date: Fri Oct 19 2007 - 01:37:38 EST


On Fri, Oct 19, 2007 at 12:27:16PM +0930, David Newall wrote:

> >Learn to read. Linux has never allowed that. Most of the Unix systems
> >do not allow that.
>
> I did read the claim and it is ambiguous, in that it can reasonably be
> read to mean that most UNIX systems never allowed such links, which is
> wrong. All UNIX systems allowed it until relatively recently.

FVO"relatively recently" exceeding a decade and half. In any case,
it's _trivial_ to get fs corruption on any system with such links -
play with rename() races a bit and you'll get it. And yes, it does
include 4.4BSD and quite a chunk of even later history.

Anyway, you are quite welcome to propose a sane locking scheme capable
of dealing with that mess.

As for the posted patch, AFAICS it's FUBAR in handling of .. in such
directories. Moreover, how are you going to keep that shadow tree
in sync with the main one if somebody starts doing renames in the
latter? Or mount --move, or...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/