Re: [PATCH] SPARC64: fix iommu sg chaining

From: David Miller
Date: Wed Oct 17 2007 - 04:33:30 EST


From: Jens Axboe <jens.axboe@xxxxxxxxxx>
Date: Wed, 17 Oct 2007 09:21:49 +0200

> On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> > Commit 2c941a204070ab32d92d40318a3196a7fb994c00 looks incomplete. The
> > helper functions like prepare_sg() need to support sg chaining too.
>
> Thanks Tomo, applied. I'll get this pushed out later today with any
> other sg chaining fallout we may see.

I'm still debugging crashes on sparc64 early on boot even with this
latest fix applied.

I think there are still problems in functions like fill_sg().

There is a lot of confusion involving loop termination. sg_next()
gives you a NULL after the last entry, but tests have been changed
to compare against sg_last() which is likely not what we want for
those checks.

I'll try to figure it out, just a heads up...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/