Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver,match eHCA and eHEA drivers

From: Jeff Garzik
Date: Tue Oct 16 2007 - 11:00:57 EST


Joachim Fenkes wrote:
On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote:
Roland Dreier <rdreier@xxxxxxxxx> wrote on 03.10.2007 20:05:44:
> > Replace struct ibmebus_dev and struct ibmebus_driver with struct
of_device
> > and struct of_platform_driver, respectively. Match the external
ibmebus
> > interface and drivers using it.
> >
> > Signed-off-by: Joachim Fenkes <fenkes@xxxxxxxxxx>
>
> This is somewhat difficult as this patch touches files that are the
> responsibility of three different maintainers. ïIs it possible to
> split the patch into three, one for each maintainer (possibly by
> keeping both old and new interfaces around for a little while)?
> > If not, then you need to get an Acked-by and an agreement that this
> change can go via the powerpc.git tree from Roland Dreier and Jeff
> Garzik.

I don't see anything objectionable in the infiniband parts of the
patch -- I don't have any way to test the changes but it all looks
like a straightforward conversion to a new platform API. So:

Acked-by: Roland Dreier <rolandd@xxxxxxxxx>

- R.
Looks good from eHEA driver perspective.

Acked-by: Jan-Bernd Themann <themann@xxxxxxxxxx>

Jeff, do you have any objections against this patch going into the kernel
via Paul's powerpc.git tree? It touches only a few lines of ehea which are
specific to the bus interface changes.

You can see the full patch here:
http://patchwork.ozlabs.org/linuxppc/patch?id=13750

If you have no objections, please ack the patch so Paul can include it.

Fine with me...

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/