Re: [PATCH 3/3] Blackfin serial driver: this driver enable SPORTs on Blackfin emulate UART

[Mike Frysinger]

On 10/11/07, Bryan Wu <bryan.wu@xxxxxxxxxx> wrote:
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> +config SERIAL_BFIN_SPORT
> +       tristate "Blackfin SPORT emulate UART (EXPERIMENTAL)"
> +       depends on BFIN && EXPERIMENTAL
> +       select SERIAL_CORE
> +       help
> +         Enble support SPORT emulate UART on Blackfin series.
> +
> +         To compile this driver as a module, choose M here: the
> +         module will be called bfin_sport_uart.
> +
> +choice
> +       prompt "Baud rate for Blackfin SPORT UART"
> +       depends on SERIAL_BFIN_SPORT
> +       default SERIAL_SPORT_BAUD_RATE_57600
> +       help
> +         Choose a baud rate for the SPORT UART, other uart settings are
> +         8 bit, 1 stop bit, no parity, no flow control.

this looks wrong to me ... why cant the standard infrastructure for
managing baud rate be used ?
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/