Re: [PATCH try #3] Input/Joystick Driver: add support AD7142joystick driver

[Jean Delvare]

On Mon, 15 Oct 2007 11:48:17 -0400, Dmitry Torokhov wrote:
> On 10/15/07, Bryan Wu <bryan.wu@xxxxxxxxxx> wrote:
> > +static int __init ad7142_init(void)
> > +{
> > +       return i2c_add_driver(&ad7142_driver);
> > +}
> > +
> > +static void __exit ad7142_exit(void)
> > +{
> > +       i2c_del_driver(&ad7142_driver);
> > +       input_unregister_device(ad7142_dev);
> 
> input_unregister_device() should be in ad7142_detach_client? I am not
> sure i2c - there seems to be 2 interface styles and you probably need
> to use the new one. I am CC-inj Jean on this.

The new style is preferred, yes.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/