Re: [2.6 patch] ivtv: fix NULL dereference

[Mauro Carvalho Chehab]

Em Dom, 2007-10-14 Ãs 20:03 +0200, Hans Verkuil escreveu:
> On Sunday 14 October 2007 19:51:37 Adrian Bunk wrote:
> > We shouldn't dereference "itv" when we know it's NULL...
> >
> > Spotted by the Coverity checker.
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> >
> > ---
> > --- linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c.old	2007-10-14
> > 19:17:12.000000000 +0200 +++
> > linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c	2007-10-14
> > 19:18:05.000000000 +0200 @@ -947,7 +947,7 @@ int
> > ivtv_v4l2_open(struct inode *inode,
> >  	if (itv == NULL) {
> >  		/* Couldn't find a device registered
> >  		   on that minor, shouldn't happen! */
> > -		IVTV_WARN("No ivtv device found on minor %d\n", minor);
> > +		printk(KERN_WARNING "No ivtv device found on minor %d\n", minor);
> >  		return -ENXIO;
> >  	}
> 
> 
> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> 
> Mauro, can you merge this with 2.6.24 as well? Or shall I add it to my 
> ivtv tree with my other outstanding fixes?

I'm applying it. I prefer to handle the fix changesets first, in
separate requests.

Later, I'll pull from your ivtv tree, together with the changesets
you're working for 2.6.25.

Btw, as I've received the patch via Adrian's e-mail, I've changed your
tag to "Reviewed-by".
 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/