Re: [patch] scsi: fix crash in gdth_timeout()

[Jeff Garzik]

Linus Torvalds wrote:
> On Mon, 15 Oct 2007, Ingo Molnar wrote:
> > A further problem is probably that the GDTH timer is not stopped by a
> > failed GDTH probe?
>
> Indeed. Maybe this is a better fix?
>
> That driver is pretty messy, and this should have been found ealier. 
> James? Boaz?

FWIW, the gdth driver was "super-messy".  With this latest SCSI pull, 
that severity has been successfully downgraded to "messy" :)

IMO some easy-to-fix breakage was inevitable with such a large volume of 
fundamental changes.

Honestly, the driver is probably rarely run by people that lack the 
hardware, I bet...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/