[PATCH] V4L: possible leak in em28xx_init_isoc

[Florin Malita]

Coverity (CID 1929) spotted the following: if a transfer buffer 
allocation fails, the last allocated urb is leaked (it hasn't been 
stored in dev->urb[] yet so em28xx_uninit_isoc misses it). The patch 
also includes a small typo fix.

Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
---

drivers/media/video/em28xx/em28xx-core.c |    3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
index d3282ec..d56484f 100644
--- a/drivers/media/video/em28xx/em28xx-core.c
+++ b/drivers/media/video/em28xx/em28xx-core.c
@@ -648,7 +648,7 @@ void em28xx_uninit_isoc(struct em28xx *dev)
 */
int em28xx_init_isoc(struct em28xx *dev)
{
-	/* change interface to 3 which allowes the biggest packet sizes */
+	/* change interface to 3 which allows the biggest packet sizes */
	int i, errCode;
	const int sb_size = EM28XX_NUM_PACKETS * dev->max_pkt_size;

@@ -673,6 +673,7 @@ int em28xx_init_isoc(struct em28xx *dev)
					("unable to allocate %i bytes for transfer buffer %i\n",
					 sb_size, i);
			em28xx_uninit_isoc(dev);
+			usb_free_urb(urb);
			return -ENOMEM;
		}
		memset(dev->transfer_buffer[i], 0, sb_size);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/