Re: [-mm Patch] drivers/net/wireless/b43/main.c: fix anuninitialized variable

From: Adrian Bunk
Date: Mon Oct 15 2007 - 08:56:27 EST


On Mon, Oct 15, 2007 at 07:34:45PM +0800, WANG Cong wrote:
>
> Fix an uninitialized variable in drivers/net/wireless/b43/main.c::b43_start().
>
> From: Adrian Bunk <bunk@xxxxxxxxxx>

A technical remark regarding these two patches:

These are your patches, not mine.

You can note formally or informally that I reported/forwarded these
issues, but I'm neither in a legal sense the author of these patches nor
am I in a technical sense responsible for their correctness [1], and a
From: tag is therefore not appropriate.

> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
>
> ---
> drivers/net/wireless/b43/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-mm1/drivers/net/wireless/b43/main.c
> ===================================================================
> --- linux-2.6.23-mm1.orig/drivers/net/wireless/b43/main.c
> +++ linux-2.6.23-mm1/drivers/net/wireless/b43/main.c
> @@ -3495,7 +3495,7 @@ static int b43_start(struct ieee80211_hw
> struct b43_wl *wl = hw_to_b43_wl(hw);
> struct b43_wldev *dev = wl->current_dev;
> int did_init = 0;
> - int err;
> + int err = 0;
>
> mutex_lock(&wl->mutex);

cu
Adrian

[1] they might or might not be correct (I don't know)

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/