Re: [PATCH] hiddev: Add 32bit ioctl compatibilty

[Philip Langdale]

Al Viro wrote:
>>
>> +static long hiddev_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>> +{
>> +	struct inode *inode = file->f_path.dentry->d_inode;
>> +	return hiddev_ioctl(inode, file, cmd, compat_ptr(arg));
>> +}
> 
> Just how many instances of that sucker do we need?  It's nothing but
> 
>      struct inode *inode = file->f_path.dentry->d_inode;
>      return file->f_op->ioctl(inode, file, cmd, compat_ptr(arg));
> 

So, I don't actually know what you're looking for, but of the 140 occasions
that .compat_ioctl is implemented in Linus' tree, I can't find another one
that actually uses this form. So, writing a shared implementation doesn't pick
off any low hanging fruit. Now, it's possible that some of the other implementations
could be reduced to this form - but for now, it seems the answer to your question
is 'one' in either case. :-)

--phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/