Re: [PATCH try #2] Input/Joystick Driver: add support AD7142joystick driver

[Bryan Wu]

On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
> Hi Bryan,
> 
> On 10/12/07, Bryan Wu <bryan.wu@xxxxxxxxxx> wrote:
> > +
[snip]
> > +
> > +static void ad7142_close(struct input_dev *dev)
> > +{
> > +       free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX, ad7142_interrupt);
> > +       kthread_stop(ad7142_task);
> 
> Don't you need to write something over i2c to shut the devoce off?
> What stops it from continuing to generate interrupts?
> 
Actually, I am going to use "completion" to replace the whole
wait_interrupt_xxx and intr_flag things which original from Aubrey. How
do you think of that?

Thanks
-Bryan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/