Re: ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMPpoweroff hangs)

[Dave Jones]

On Thu, Oct 11, 2007 at 02:42:01PM -0400, Jeff Garzik wrote:
 > Linus Torvalds wrote:
 > > 
 > > And I think I see the problem: it's a config change. You don't have 
 > > PM_LEGACY enabled. Your config file diff shows:
 > > 
 > > 	-CONFIG_PM_LEGACY=y
 > > 	+# CONFIG_PM_LEGACY is not set
 > > 
 > > I suspect we should make CONFIG_APM either depend on, or select, 
 > > PM_LEGACY. But as far as I can see, nothing has actually changed in this 
 > > area in the kernel, and this bug has been there before - just your config 
 > > change made it appear. 
 > > 
 > > Rafael? Stephen? Opinions? I'd think that making APM depend on 
 > > CONFIG_PM_LEGACY is the right thing to do these days..
 > 
 > Speaking as the author of
 > 
 > 	[PATCH] move pm_register/etc. to CONFIG_PM_LEGACY, pm_legacy.h
 > 
 > I agree.  arch/i386/kernel/apm.c clearly requires 
 > include/linux/pm_legacy.h and the legacy PM API.
 > 
 > I would vote for a dependency rather than select, but don't have any 
 > strong feelings on the matter...

gti revert 987d4613e52e4f655278265aabbcc69237018b1d
should do the trick.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/