Re: [PATCH 2/3] Re: sil3114 data corruption

From: Bernd Schubert
Date: Thu Oct 11 2007 - 08:20:52 EST


This will add the sil3114 back to the controllers with the mod15 bug. Without
this patch no workaround for this controller is done and people might/will
suffer from data corruption.

Also rather trivial, though with a huge effect, the speed for the effected
disks will go down from about 45-50MB/s to 20-25MB/s. But better safe than
lost data or damaged filesystem.

Signed-off-by: Bernd Schubert <bs@xxxxxxxxx>

Index: linux-2.6.23-rc9/drivers/ata/sata_sil.c
===================================================================
--- linux-2.6.23-rc9.orig/drivers/ata/sata_sil.c 2007-10-11 10:45:02.000000000
+0200
+++ linux-2.6.23-rc9/drivers/ata/sata_sil.c 2007-10-11 10:45:08.000000000
+0200
@@ -241,7 +241,8 @@ static const struct ata_port_info sil_po
},
/* sil_3114 */
{
- .flags = SIL_DFL_PORT_FLAGS | SIL_FLAG_RERR_ON_DMA_ACT,
+ .flags = SIL_DFL_PORT_FLAGS | SIL_FLAG_RERR_ON_DMA_ACT
+ | SIL_FLAG_MOD15WRITE,
.pio_mask = 0x1f, /* pio0-4 */
.mwdma_mask = 0x07, /* mwdma0-2 */
.udma_mask = ATA_UDMA5,



--
Bernd Schubert
Q-Leap Networks GmbH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/