Re: [PATCH -mm] slub: fix cpu hotplug offline/online path

From: Christoph Lameter
Date: Tue Oct 09 2007 - 14:46:38 EST


On Wed, 10 Oct 2007, Akinobu Mita wrote:

> This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
> call it for each possible CPUs not only online CPUs at initialization time.

Could you check if a per cpu structure has already been allocated and then
simply skip the call to init? Otherwise we end up with lots of per cpu
structures for cpus that will never show up.

if (!get_cpu_slab(s, cpu))
init_alloc_cpu_cpu( ...)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/