Re: RFC: reviewer's statement of oversight

[Jonathan Corbet]

Al Viro <viro@xxxxxxxxxxxxxxxx> wrote:

> > A patch which is not "worthwhile" is also not "appropriate".  Mere
> > correctness in a mathematical sense is not enough as technical review
> > criterion.
> 
> Yes, but there's also such thing as "worthwhile removal".

Good point.  So the text should probably say "worthwhile change" rather
than "worthwhile addition."  I do believe that thinking about whether
the change as a whole is a desirable thing is an important part of the
review process.

jon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/