Re: [PATCH]fix page release issue in filemap_fault

From: Rik van Riel
Date: Mon Oct 08 2007 - 13:23:47 EST


On Mon, 08 Oct 2007 19:15:23 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Mon, 2007-10-08 at 23:28 +0800, Yan Zheng wrote:
> > Hi all
> >
> > find_lock_page increases page's usage count, we should decrease it
> > before return VM_FAULT_SIGBUS
> >
> > Signed-off-by: Yan Zheng<yanzheng@xxxxxxxx>
>
> Nice catch, .23 material?

An obvious fix for a memory leak. I think it should go in.

> Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/