Re: [PATCH] [2/6] scheduler: Refactor common code of sleep_on /wait_for_completion v2

From: Ingo Molnar
Date: Mon Oct 08 2007 - 08:03:29 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> > Andi Kleen <ak@xxxxxxx> writes:
> >
> > > These functions were largely cut'n'pasted. This moves
> >
> > Here's a replacement patch fixing a minor problem:
> > sleep_on_common wasn't marked __sched and ended up in the
> > wrong section; breaking the WCHAN backtracing.
>
> thanks, applied.

btw., this is a very nice cleanup, the .text savings are particularly
impressive:

text data bss dec hex filename
24545 2406 16 26967 6957 sched.o.before
23687 2406 16 26109 65fd sched.o.after

almost 1K of text shaven off! :)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/