Re: [PATCH] net/core: split dev_ifsioc() according to locking

From: David Miller
Date: Mon Oct 08 2007 - 03:07:11 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Sun, 7 Oct 2007 02:17:08 +0200

> On Saturday 06 October 2007, Jeff Garzik wrote:
> >
> > This always bugged me:  dev_ioctl() called dev_ifsioc() either inside
> > read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being
> > executed.
> >
> > This change moves the ioctls executed inside dev_base_lock to a new
> > function, dev_ifsioc_locked().  Now the locking context is completely
> > clear to the reader.
> >
> > Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
>
> Great idea!

I think so too, applied, thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/