Re: [PATCH] Cute feature: colored printk output

[Krzysztof Halasa]

Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> writes:

> +	The value you need to enter here is the ASCII color value

ASCII color value? ANSI perhaps?

> +	composed (OR'ed) by one foreground color, one background
> +	color and any number of attributes as follows:

I'm certainly not a native English writer, though I think it
should be "composed of" or maybe "composed from".

"one" doesn't sound well in my ears, either.

> +	Using "highlight foreground" is said not work when you use

I'd say "HF is known not to work with VGA console" or just
"HF doesn't work with VGA console".


I wonder how accurate is it.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/