Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

[Bernardo Innocenti]

On 10/05/2007 09:15 AM, Pavel Machek wrote:

> > This patch merges the fb_powerup and fb_powerdown hooks in a single
> > operation fb_power with an additional "state" parameter ranging
> > from 0 (running) to 3 (poweroff).
>
> No, please don't. Having int with 0/3 being valid specifying what to
> do is evil.
>
> enum is less evil, but what's wrong about having 3 functions?

Later on, the patch was reworked by Jordan Crouse to use
the fb_blank hook instead, which already has enough states.

So the fb_powerup/fb_powerdown hooks, which were not yet
upstream anyway, died off in the process.

--
\___/
|___|  Bernardo Innocenti - http://www.codewiz.org/
 \___\ One Laptop Per Child - http://www.laptop.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/