Re: [PATCH] Fix SH DMAC code to handle PVR2 cascade

From: Adrian McMenamin
Date: Thu Oct 04 2007 - 07:42:47 EST


On Thu, October 4, 2007 11:01 am, Paul Mundt wrote:
> So for PVR2 cascade, what does the CHCR value work out to? Both
> CHCR_TS_MASK and CHCR_TS_SHIFT haven't changed for SH7750, so this
> suggests that either the CHCR value is just wrong or we've had a
> long-standing bug with the CHCR.TS mask.
>
> Either way, we are not going to hardcode a ts_shift value when the CHCR
> has all of the information encoded in it!
>

There *is* a long standing bug in CHCR_TS_MASK. It is meant to mask out
all but bits 6:4 but in fact only masks bits 5 and 4. If it is set to 0x70
and not 0x30 this should work - though as usual I cannot make a patch to
check this out at the moment.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/