Re: -rt scheduling: wakeup bug?

[Ingo Molnar]

* Mike Kravetz <kravetz@xxxxxxxxxx> wrote:

> >  	if (rq->curr && p && rq && _need_resched())
> >  		trace_special_pid(p->pid, PRIO(p), PRIO(rq->curr));
> 
> Not an issue with the patch, just that last bit of code pulled in for 
> context.  I don't think it is a bug, but the checking of 'rq' after 
> checking 'rq->curr' just doesn't look right (or necessary).  Could it 
> just be an artifact from earlier versions of the code?

yeah, you are right - and rq shouldnt ever be NULL there anyway.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/