Re: [PATCH 03/33] task containersv11 add tasks file interface

From: Paul Jackson
Date: Wed Oct 03 2007 - 22:47:20 EST


> > - There are many instances of the local variable 'cont', referring
> > to a struct cgroup pointer. I presume the spelling 'cont' is a
> > holdover from the time when we called these containers.
>
> Yes, and since cgroup is short for "control group", "cont" still
> seemed like a reasonable abbreviation. (And made the automatic
> renaming much simpler).

The following will change all 'cont' words to your choice (I doubt
you want to use 'XXXX' as I did here) in cgroup.c:

sed -i -r 's/(\W|^)cont(\W|$)/\1XXXX\2/g' kernel/cgroup.c

I can't say for sure, but I suspect that if cgroups had always
been cgroups (short for control groups), then these local 'cont'
variables would have a different name. One can often, as in this
case, find some justification for most any name. The question is
which name is most quickly and easily understood.

... yes ... I'm a stickler for names ... sorry.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/