Re: [PATCH 5/5] lguest: loading bzImage directly

From: H. Peter Anvin
Date: Wed Oct 03 2007 - 13:13:26 EST


Chris Malley wrote:
Hi guys

Would it not be clearer to #include <asm/bootparam.h> and use the relevant named members of struct setup_header / struct boot_params
rather than the hard-coded values 0x202, 0x1F1, 0x214 ?


Yes, please. I have a patch in -mm which already does that across the kernel.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/