Re: [PATCH] sky2: jumbo frame regression fix

[Jeff Garzik]

Stephen Hemminger wrote:
> On Tue, 02 Oct 2007 21:07:22 -0400
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> > Stephen Hemminger wrote:
> > > Remove unneeded check that caused problems with jumbo frame sizes.
> > > The check was recently added and is wrong.
> > > When using jumbo frames the sky2 driver does fragmentation, so
> > > rx_data_size is less than mtu.
> > >
> > > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
> > >
> > > --- a/drivers/net/sky2.c	2007-10-02 17:56:31.000000000 -0700
> > > +++ b/drivers/net/sky2.c	2007-10-02 17:58:56.000000000 -0700
> > > @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru
> > >  	sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending;
> > >  	prefetch(sky2->rx_ring + sky2->rx_next);
> > >  
> > > -	if (length < ETH_ZLEN || length > sky2->rx_data_size)
> > > -		goto len_error;
> > > -
> > 2.6.23?  2.6.24?  enquiring minds want to know...
>
> 2.6.23, since it is a regression

You can have regressions in behavior in net-2.6.24.git, too.  _Please_ 
be specific about where you want your patches to go.  Thanks.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/