Re: x86 patches was Re: -mm merge plans for 2.6.24

[Andy Whitcroft]

On Tue, Oct 02, 2007 at 09:01:10AM +0200, Andi Kleen wrote:

> x86_64-sparsemem_vmemmap-2m-page-size-support.patch
> x86_64-sparsemem_vmemmap-vmemmap-x86_64-convert-to-new-helper-based-initialisation.patch          
> Look like these two should be merged together
>
> Also I'm concerned about a third variant of memmappery. Can we agree
> to only merge that when the old sparsemem support is removed from x86-64? 
> 
> Otherwise it looks good to me.

sparsemem vmemmap is a sparsemem variant.  By that I mean that it uses all
the same infrastructure as sparsemem.  That sparsemem code is generic code
and shared with the other architectures.  There essentially is no code to
remove which is not generic and currently in use by other architectures.
The patches as they stand select the vmemmap variant unconditionally
when sparsemem is selected, we are not adding a new option for x86_64
overall -- in that sense classic sparsemem is already removed for x86_64
by these patches.

The longer plan is to pull out the other memory models where they are
no longer beneficial with a view to ending up with only one.  A good
example is the private virtual memory map implemented on ia64, which
is an early target.  As discussed at VM summit, we are also looking at
removing discontigmem for x86.  That review will continue.

> > How come?  Memoryless node can and do occur in real-world machines.  Kernel
> > should support that?
> 
> But a node is just defined by its memory? 

I thought that a node was a unit of numa locality.  Cirtainly some
machines seem to express themselves as memory only nodes and cpu only
nodes; in the past I am sure we have also heard of IO only nodes
representing "io drawers" and the like.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/